Improves DataItem validation #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #3
The implementation of ANS104 is not correct, but it's too late to fix that, ANS104 must be adapted instead.
However it's still not too late to enlarge the limits in a backwards compatible way such that it resembles the spec a little bit more.
HyperBeam has a similar problem, so we'll have to open a PR for that too, but this change shouldn't break it.
A note: if a dataitem is created according to the new rules, projects that don't update their library could fail to validate new (bigger) dataitems, but that's probably acceptable.
Here's a recap on the status quo and the proposed changes