Skip to content

Rollover details summary shows new school model data - #6317

Open
gms-gs wants to merge 1 commit into
mainfrom
gs-rollover-schools-summary
Open

Rollover details summary shows new school model data#6317
gms-gs wants to merge 1 commit into
mainfrom
gs-rollover-schools-summary

Conversation

@gms-gs

@gms-gs gms-gs commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Context

The automated rollover progress summary displayed counts for providers, courses, study sites and partnerships, but not schools from the new school data model.

Changes proposed in this pull request

  • Add eligible and rolled-over Provider::School counts to the rollover progress query.
  • Exclude closed GIAS schools, matching rollover behaviour.
  • Display a new “Rolled over schools” row in the rollover progress summary.
  • Add test coverage for eligible and rolled-over school counts.
  • Keep existing study-site progress unchanged.

Guidance to review

  • Confirm the school count includes only available schools belonging to eligible providers.
  • Confirm closed schools and schools belonging to ineligible providers are excluded.
  • Confirm the rollover summary displays the rolled-over and expected school counts.
  • Run:
bundle exec rspec spec/queries/rollover_progress_query_spec.rb

Checklist

  • I have moved hard-coded strings to locale files.
  • I have removed the usage of data-qa attributes in HTML files and updated the corresponding tests.

@gms-gs

gms-gs commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Question is do we keep the study site counts for now or remove also?

@gms-gs gms-gs added the deploy A Review App will be created for PRs with this label label Aug 13, 2026
@github-actions

Copy link
Copy Markdown

@gms-gs
gms-gs marked this pull request as ready for review August 13, 2026 12:56
@gms-gs
gms-gs requested a review from a team as a code owner August 13, 2026 12:56
@gms-gs

gms-gs commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy A Review App will be created for PRs with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant