Add new /health/info endpoint #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#54 This is in support of the new service-status page we're building in the [water-abstraction-system repo](https://github.com/DEFRA/water-abstraction-system). We want to be able to show both the version and commit hash for each service in that page. The existing `/status` page does include the `package.json` version. But that endpoint is also used for the AWS load balancer health check so is heavily hit. We don't want to make it do more work and get the commit hash as well. Instead, we add a new `/health/` path and a new `/info` endpoint to return both the version and commit hash.
We want the endpoint available in both internal and external apps. So, we add the functionality to the shared folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#54
This supports the new service-status page we're building in the water-abstraction-system repo.
We want to be able to show both the version and commit hash for each service on that page. The existing
/statuspage does include thepackage.jsonversion. But that endpoint is also used for the AWS load balancer health check so is heavily hit. We don't want to make it do more work getting the commit hash.Instead, we add a new
/health/path and a new/infoendpoint to return both the version and commit hash.