Move UUID generation to single place #96
Assignees
Labels
housekeeping
Refactoring, tidying up or other work which supports the project
Comments
Cruikshanks
added
the
housekeeping
Cruikshanks
added a commit
to DEFRA/water-abstraction-system
that referenced
this issue
Sep 8, 2023
DEFRA/water-abstraction-team#96 There are a number of places in [water-abstraction-system](https://github.com/DEFRA/water-abstraction-system) where we need to generate a [UUID](https://en.wikipedia.org/wiki/Universally_unique_identifier). This is what the records in the DB use for their primary keys. We generate them in tests, for performance reasons (reduce hits on the DB) or simply because the previous team forgot to set the table to automatically generate them! You have to `require()` the module and then it's a one-liner to generate the method. So, moving it to our own thing didn't seem necessary. But there is some config you need to apply, and we have duplicated that in a number of places. Who knows where a new dev will encounter `randomUUID({ disableEntropyCache: true })` for the first time! 😆 Admittedly, it's borderline whether there is value in doing this. But we've come to the conclusion we should.
Cruikshanks
added a commit
to DEFRA/water-abstraction-system
that referenced
this issue
Sep 11, 2023
DEFRA/water-abstraction-team#96 There are a number of places in [water-abstraction-system](https://github.com/DEFRA/water-abstraction-system) where we need to generate a [UUID](https://en.wikipedia.org/wiki/Universally_unique_identifier). This is what the records in the DB use for their primary keys. We generate them in tests, for performance reasons (reduce hits on the DB) or simply because the previous team forgot to set the table to automatically generate them! You have to `require()` the module and then it's a one-liner to generate the method. So, moving it to our own thing didn't seem necessary. But there is some config you need to apply, and we have duplicated that in a number of places. Who knows where a new dev will encounter `randomUUID({ disableEntropyCache: true })` for the first time! 😆 Admittedly, it's borderline whether there is value in doing this. But we've come to the conclusion we should
|
This is done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a number of places in water-abstraction-system where we need to generate a UUID. This is what the records in the DB use for their primary keys. We generate them in tests, for performance reasons (reduce hits on the DB) or simply because the previous team forgot to set the table to automatically generate them!
You have to
require()the module and then it's a one-liner to generate the method. So, moving it to our own thing didn't seem necessary.But there is some config you need to apply, and we have duplicated that in a number of places. Who knows where a new dev will encounter
randomUUID({ disableEntropyCache: true })for the first time! 😆Admittedly, it's borderline whether there is value in doing this. But we've come to the conclusion we should.
The text was updated successfully, but these errors were encountered: