Exclude long strings from ESLint max-len rule #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#115 Whilst we should be making every effort to keep lines shorter than 120 characters the intent for the rule is to stop folks from stringing together complex one-liners. There are times we need to include long pieces of text, build strings from verbose variable names or reference URLS that will cause us to go over the limit. We don't want to make them more complex just for the sake of a linter. So, we add this config to exclude these types from the rule.
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
robertparkinson
approved these changes
May 8, 2024
rvsiyad
approved these changes
May 8, 2024
Cruikshanks
added a commit
that referenced
this pull request
May 12, 2024
DEFRA/water-abstraction-team#115 In [Exclude long strings from ESLint max-len rule](#992) we updated our ESLint [max-len](https://eslint.style/rules/js/max-len) to exclude long strings or template literals from being flagged as issues. That reduced the noise (there were lots of infractions!) and helped us see actual long lines of logic which should be refactored. This fixes all the remaining `max-len` infractions.
Cruikshanks
added a commit
that referenced
this pull request
May 12, 2024
DEFRA/water-abstraction-team#115 In [Exclude long strings from ESLint max-len rule](#992) we updated our ESLint [max-len](https://eslint.style/rules/js/max-len) to exclude long strings or template literals from being flagged as issues. That reduced the noise (there were lots of infractions!) and helped us see actual long lines of logic which should be refactored. This fixes all the remaining `max-len` infractions.
Cruikshanks
added a commit
that referenced
this pull request
May 12, 2024
DEFRA/water-abstraction-team#115 In [Exclude long strings from ESLint max-len rule](#992) we updated our ESLint [max-len](https://eslint.style/rules/js/max-len) to exclude long strings or template literals from being flagged as issues. That reduced the noise (there were many infractions!) and helped us see long lines of logic that should be refactored. This fixes all the remaining `max-len` infractions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#115
Whilst we should be making every effort to keep lines shorter than 120 characters the intent of the rule is to stop folks from stringing together complex one-liners.
Sometimes we need to include long pieces of text, build strings from verbose variable names or reference URLS that will cause us to exceed the limit.
We don't want to make them more complex just for the sake of a linter. So, we add this config to exclude these lines of these types from the rule.