Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the returns and bills empty message #990

Merged
merged 2 commits into from
May 8, 2024

Conversation

jonathangoulding
Copy link
Collaborator

@jonathangoulding jonathangoulding commented May 8, 2024

https://eaflood.atlassian.net/browse/WATER-4444

An assumption was made previously that the returned value would be null when there were no bills/ returns. This was an over site, and it would obviously always be an array.

This fix will check the array is > 0 to determine when to show the table or the empty message.

An assumption was made previously that the returned value would be null when there were no bills/ returns. This was an over site, and it would obviously always be an array.

This fix will check the array is > 0 to determine when to show the table or the empty message.
@jonathangoulding jonathangoulding self-assigned this May 8, 2024
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathangoulding jonathangoulding merged commit b5f4a3b into main May 8, 2024
6 checks passed
@jonathangoulding jonathangoulding deleted the fix-view-licence-table-empty-messages branch May 8, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants