Add View Licence Bills page #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4316 The existing service handling view licence is slow because it loads all the data for the tabs in one render. Work has been done previously to refactor the summary page to load only the summary information. This change will introduce a bills controller, service and presenter to handle the view licence bills page. This will share the same view as the summary page and load the same 'common data' established in [previous work](#957).
jonathangoulding
added
the
housekeeping
jonathangoulding
commented
May 7, 2024
jonathangoulding
commented
May 7, 2024
jonathangoulding
commented
May 7, 2024
| const billsData = await FetchLicenceBillsService.go(licenceId, page) | ||
| const pageData = ViewLicenceBillsPresenter.go(billsData.bills) | ||
|
|
||
| const pagination = PaginatorPresenter.go(100, Number(page), `/system/licences/${licenceId}/bills`) |
There was a problem hiding this comment.
confirm this works with a bigger license
There was a problem hiding this comment.
I have checked and this does work when the numbers are fudged. But it would be better to test with a licence with more data.
robertparkinson
requested changes
May 7, 2024
robertparkinson
approved these changes
May 7, 2024
Cruikshanks
added a commit
that referenced
this pull request
May 14, 2024
https://eaflood.atlassian.net/browse/WATER-4316 In [Add View Licence Bills page](#986) we added support for displaying the bills linked to a licence in the view licence page's 'Bills' tab. Only we didn't spot that it should only be 'sent' bills. This change updates the relevant fetch service to ensure the bills we get back are only those with a status of 'sent'.
Cruikshanks
added a commit
that referenced
this pull request
May 14, 2024
https://eaflood.atlassian.net/browse/WATER-4316 In [Add View Licence Bills page](#986) we added support for displaying the bills linked to a licence in the view licence page's 'Bills' tab. Only we didn't spot that it should only be 'sent' bills. This change updates the relevant fetch service to ensure the bills we get back are only those with a status of 'sent'.
Cruikshanks
added a commit
that referenced
this pull request
May 14, 2024
https://eaflood.atlassian.net/browse/WATER-4316 In [Add View Licence Bills page](#986) we added support for displaying the bills linked to a licence in the view licence page's 'Bills' tab. Only we didn't spot that it should only be 'sent' bills. This change updates the relevant fetch service to ensure the bills we get back are only those with a status of 'sent'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4316
The existing service handling view licence is slow because it loads all the data for the tabs in one render. Work has been done previously to refactor the summary page to load only the summary information.
This change will introduce a bills controller, service and presenter to handle the view licence bills page.
This will share the same view as the summary page and load the same 'common data' established in previous work.