Update bill run setup journey to use new session #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4463 We created our `SessionModel` and its backing table out of the need to be able to store data temporarily, for example, when a user is following a journey to create a new return requirement. After using it in our bill run setup and return requirement journeys we spotted there were some improvements we could make. So, we [Enhanced the SessionModel to expose and update data](#981). The next step is to update the existing journeys to take advantage of these enhancements. In this change we update the bill run setup journey. We'll update the return requirements journey in the next change.
Cruikshanks
added
the
housekeeping
As the note explains. The enhancements mean we cannot just instantiate an instance and pass it in like we'd just fetched it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4463
We created our
SessionModeland its backing table out of the need to be able to store data temporarily, for example, when a user is following a journey to create a new return requirement.After using it in our bill run setup and return requirement journeys we spotted there were some improvements we could make. So, we Enhanced the SessionModel to expose and update data.
The next step is to update the existing journeys to take advantage of these enhancements.
In this change, we update the bill run setup journey. We'll update the return requirements journey in the next change.