Rename add-note route in ret. requirements to note #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4261 The `/add-note` route on the return requirements setup journey is inconsistent with the rest of our routes because it is the only one that includes a verb. This really becomes a problem when we have to go to the same endpoint to change an existing note; it no longer makes sense. So, this change is some housekeeping to get the route name inline with the others and use simply `/note`.
Cruikshanks
added
the
housekeeping
Should have spotted this in review! 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4261
The
/add-noteroute on the return requirements setup journey is inconsistent with the rest of our routes because it is the only one that includes a verb. This becomes a problem when we have to go to the same endpoint to change an existing note; it no longer makes sense.So, this change is some housekeeping to get the route name in line with the others and use simply
/note.