Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model relationship for return logs & licences #972

Merged
merged 7 commits into from
May 3, 2024

Conversation

Cruikshanks
Copy link
Member

https://eaflood.atlassian.net/browse/WATER-4444

We are working on replacing the legacy view licence page. One of the tabs shows the return logs for a licence. To aid in fetching them we are adding an objection.js model relationship between ReturnLogModel and LicenceModel.

https://eaflood.atlassian.net/browse/WATER-4444

We are working on replacing the legacy view licence page. One of the tabs shows the return logs for a licence. To aid fetching them we are adding [an objection.js model relationship](https://vincit.github.io/objection.js/guide/relations.html#examples) between `ReturnLogModel` and `LicenceModel`.
@Cruikshanks Cruikshanks added the housekeeping Refactoring, tidying up or other work which supports the project label May 2, 2024
@Cruikshanks Cruikshanks self-assigned this May 2, 2024
@Cruikshanks Cruikshanks marked this pull request as ready for review May 2, 2024 21:42
@Cruikshanks Cruikshanks merged commit 497a671 into main May 3, 2024
6 checks passed
@Cruikshanks Cruikshanks deleted the add-return-log-licence-relationship branch May 3, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants