SRoC Supplementary Billing - Determine Abstraction Period #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3834 As part of determining the transactions and Billable Days for Supplementary Billing, the Abstraction Period needs to be taken into account. Abstraction period is the date range in which Licence Holders can abstract water, in terms of Supplementary Billing, then it needs to be taken into account days when the Licence Holder cannot abstract as the dates are outside of the Abstraction Period and therefore not chargeable. This PR is to determine the correct number of billable days in the abstraction period.
StuAA78
requested changes
Jan 24, 2023
app/services/supplementary-billing/abstraction-billing-period.service.js
Outdated
Show resolved
Hide resolved
app/services/supplementary-billing/abstraction-billing-period.service.js
Outdated
Show resolved
Hide resolved
app/services/supplementary-billing/abstraction-billing-period.service.js
Outdated
Show resolved
Hide resolved
app/services/supplementary-billing/abstraction-billing-period.service.js
Outdated
Show resolved
Hide resolved
Cruikshanks
requested changes
Jan 25, 2023
There was a problem hiding this comment.
@StuAA78 has raised some good points which are mainly hangovers from by first stab at this service 😳 😬 .
But I also believe there is no point working out billable dates and billable days for an abstraction period that isn't going to be considered.
app/services/supplementary-billing/abstraction-billing-period.service.js
Outdated
Show resolved
Hide resolved
I've removed the `_flagPeriodsForConsideration` function as it's no longer required. We are now chceking if an abstraction period is valid and not including it in the array at all if it isn't. New function `_isPeriodValid` created to check if period is valid.
Cruikshanks
requested changes
Jan 26, 2023
app/services/supplementary-billing/abstraction-billing-period.service.js
Outdated
Show resolved
Hide resolved
app/services/supplementary-billing/abstraction-billing-period.service.js
Outdated
Show resolved
Hide resolved
app/services/supplementary-billing/abstraction-billing-period.service.js
Outdated
Show resolved
Hide resolved
app/services/supplementary-billing/abstraction-billing-period.service.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
StuAA78
approved these changes
Jan 26, 2023
Jozzey
added a commit
that referenced
this pull request
Feb 6, 2023
https://eaflood.atlassian.net/browse/WATER-3894 Thanks to #97 we now know what the billable days are for each abstraction period (charge_purpose) linked to a charge reference (charge_element && billing_charge_categories) within a charge version. The final step is to take that information and start generating the transaction line information. For each charge reference in a charge version, there should be one transaction line. So, if a charge reference is linked to multiple abstraction periods, we need the sum of their billable days.
Jozzey
added a commit
that referenced
this pull request
Feb 13, 2023
https://eaflood.atlassian.net/browse/WATER-3894 Thanks to #97 we now know what the billable days are for each abstraction period (`charge_purpose`) linked to a charge reference (`charge_element` && `billing_charge_categories`) within a charge version. The final step is to take that information and start generating the transaction line information. For each charge reference in a charge version, there should be one transaction line. So, if a charge reference is linked to multiple abstraction periods, we need the sum of their billable days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3834
As part of determining the transactions and Billable Days for Supplementary Billing, the Abstraction Period needs to be taken into account. Abstraction period is the date range in which Licence Holders can abstract water, in terms of Supplementary Billing, then it needs to be taken into account days when the Licence Holder cannot abstract as the dates are outside of the Abstraction Period and therefore not chargeable.
This PR is to determine the correct number of billable days in the abstraction period.