Add View License Returns page #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing service handling view license is slow because it loads all the data for the tabs in one render. Work has been done previously to refactor the summary page to load only the summary information. This change will introduce a returns controller, service and presenter to handle the view license returns page. This will share he same view as the summary page and load the same 'common data' established in previous work. Both pieces of work are part of - https://eaflood.atlassian.net/browse/WATER-4444 Previous work as mentioned above - #957
get data from returns table format data to presenter update tests
add description to table row items
|
Need to implement the no returns tab / view. |
remove comment block update fetch service returns to use returnlog relation
update the the if in license returns to share the link
rename spelling
…page # Conflicts: # app/routes/licence.routes.js
robertparkinson
requested changes
May 3, 2024
Cruikshanks
requested changes
May 3, 2024
There was a problem hiding this comment.
They are nearly all just nit-picks which hopefully soon ESLint will save me from highlighting (or more often missing!)
I've also seen @robertparkinson got in there before me and I concur with what he is saying.
Cruikshanks
requested changes
May 3, 2024
jonathangoulding
force-pushed
the
view-licence-returns-page
branch
from
8eb5c00 to
b895c74
Compare
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
…view-licence-returns-page
Co-authored-by: Alan Cruikshanks <[email protected]>
Cruikshanks
requested changes
May 3, 2024
Co-authored-by: Alan Cruikshanks <[email protected]>
Cruikshanks
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4444
The existing service handling view license is slow because it loads all the data for the tabs in one render. Work has been done previously to refactor the summary page to load only the summary information.
This change will introduce a returns controller, service and presenter to handle the view license returns page.
This will share the same view as the summary page and load the same 'common data' established in previous work.