Persist charge reference authorised volume for two-part tariff review #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4435 https://eaflood.atlassian.net/browse/WATER-4440 As part of the work on our two-part tariff review screens we are now building new pages to edit the authorised volume for the charge reference. This PR is the prep work for those pages, adding the charge reference authorised volume into our persisted data and an amended column for it as well. This PR also covers a content change on the review licence page, where authorised volume is shown, but is currently worked out by adding up the totals of the authorised volumes from the charge elements. This is being changed to the authorised volume on the charge reference instead.
Cruikshanks
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4435
https://eaflood.atlassian.net/browse/WATER-4440
As part of the work on our two-part tariff review screens we are now building new pages to edit the authorised volume for the charge reference. This PR is the prep work for those pages, adding the charge reference authorised volume into our persisted data and an amended column for it as well. This PR also covers a content change on the review licence page, where authorised volume is shown, but is currently worked out by adding up the totals of the authorised volumes from the charge elements. This is being changed to the authorised volume on the charge reference instead.