Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to Check Your Answers after making a change #959

Merged
merged 5 commits into from
May 1, 2024

Conversation

rvsiyad
Copy link
Contributor

@rvsiyad rvsiyad commented Apr 30, 2024

This is a PR focused on adding the ability to return to the Check Your Answers page after updating a previously submitted page in the return requirements journey.

When a user reaches the Check Your Answers page at the end of the return requirements journey, they are given the ability to update previously entered options. After making a change, users should be navigated back to the Check Your Answers page instead of continuing through the already completed journey.

This is a PR focused on adding the ability to return to the Check Your Answers page after
updating a previously submitted page in the return requirements journey.

When a user reaches the Check Your Answers page at the end of the return requirements journey,
they are given the option to update previously entered options. After making a change, users
should be navigated back to the Check Your Answers page instead of continuing through the
already completed journey.
@rvsiyad rvsiyad added the enhancement New feature or request label Apr 30, 2024
@rvsiyad rvsiyad self-assigned this Apr 30, 2024
@rvsiyad
Copy link
Contributor Author

rvsiyad commented May 1, 2024

SonarCloud is currently failing for this PR as it is complaining about the lack of test code coverage for the Return Requirements Controller. This is as a result of missing test cases for POST requests for the Return Requirements journey.

After consulting on the issue with @Cruikshanks, the tests will be implemented at a later date when the Return Requirements journey is fully completed.

SonarCloud can be ignored for now 🎉 🤘

@rvsiyad rvsiyad marked this pull request as ready for review May 1, 2024 11:31
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂 🎉 !!

But just a heads up, we'll be returning to this for 'reasons' 😏 😁

@rvsiyad rvsiyad merged commit c05be58 into main May 1, 2024
5 of 6 checks passed
@rvsiyad rvsiyad deleted the return-requirements-return-to-check-answers branch May 1, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants