Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new queued bill run status #95

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

Cruikshanks
Copy link
Member

https://eaflood.atlassian.net/browse/WATER-3877

When a supplementary bill run is started, we'll be creating both a PRESROC and SROC one at the same time.

The PRESROC one will then begin processing (labelled as BUILDING in the UI) whilst the SROC one is queued waiting to be processed.

At the moment though, all we can do is initialise the SROC bill run with a status of processing as that is all that is available to us. In the UI this will give the impression both are building when they're not.

We've added a new queued status to water-abstraction-service and support for it in water-abstraction-ui. This change updates changes the default status we apply to new bill runs to be queued.

https://eaflood.atlassian.net/browse/WATER-3877

When a supplementary bill run is started, we'll be creating both a PRESROC and SROC one at the same time.

The PRESROC one will then begin `processing` (labelled as BUILDING in the UI) whilst the SROC one is `queued` waiting to be processed.

At the moment though, all we can do is initialise the SROC bill run with a status of `processing` as that is all that is available to us. In the UI this will give the impression both are building when they're not.

We've added a new `queued` status to [water-abstraction-service](https://github.com/DEFRA/water-abstraction-service) and support for it in [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui). This change updates changes the default status we apply to new bill runs to be `queued`.
@Cruikshanks Cruikshanks added the enhancement New feature or request label Jan 23, 2023
@Cruikshanks Cruikshanks self-assigned this Jan 23, 2023
@Cruikshanks Cruikshanks marked this pull request as ready for review January 23, 2023 09:58
Copy link
Contributor

@Jozzey Jozzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cruikshanks Cruikshanks merged commit d7b0c48 into main Jan 24, 2023
@Cruikshanks Cruikshanks deleted the support-new-queued-bill-run-status branch January 24, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants