Display view licence tabs only to permitted users #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangoulding
requested review from
Cruikshanks and
robertparkinson
and removed request for
Cruikshanks
| @@ -71,7 +71,8 @@ function go (licence, licenceAbstractionConditions) { | |||
| registeredTo, | |||
| sourceOfSupply: abstractionDetails.sourceOfSupply, | |||
| startDate: formatLongDate(startDate), | |||
| warning: _generateWarningMessage(ends) | |||
| warning: _generateWarningMessage(ends), | |||
| roles: _getAuthRoles(auth) | |||
There was a problem hiding this comment.
Started to get a sonar cloud error - https://sonarcloud.io/project/issues?resolved=false&severities=MAJOR&sinceLeakPeriod=true&branch=view-license-role-based-tabs-for-bills-and-charge-information&id=DEFRA_water-abstraction-system&open=AY8pIrHhp7fcpGn2GYJe
this did not happen when the notification work was done.
jonathangoulding
force-pushed
the
view-license-role-based-tabs-for-bills-and-charge-information
branch
2 times, most recently
from
ae89fc5 to
fb99f03
Compare
Cruikshanks
requested changes
Apr 29, 2024
https://eaflood.atlassian.net/browse/WATER-4432 > Part of a series of changes to replace the legacy view licence page This change will only show the billing and charge information tabs on the view license page if the user has the appropriate role.
jonathangoulding
force-pushed
the
view-license-role-based-tabs-for-bills-and-charge-information
branch
from
0ef4de3 to
42f40e5
Compare
jonathangoulding
changed the title
Cruikshanks
added
the
security
…harge-information
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
…harge-information
jonathangoulding
deleted the
view-license-role-based-tabs-for-bills-and-charge-information
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display view licence tabs only to permitted users
https://eaflood.atlassian.net/browse/WATER-4432
This change will only show the billing and charge information tabs on the view license page if the user has the appropriate role.