Add validation for amend billable returns page #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4370 During the testing of the amend billable returns volume page it was highlighted that there was 1 validation test missing. When a user enters a new volume for the billable returns, the volume currently cannot be greater then the authorised volume on the charge reference. This is correct however it should also not go above the charge reference authorised volume as well. So whichever volume is LOWER the authorised charge element or the authorised charge reference. This PR is to add in that additional validation.
Jozzey
requested changes
Apr 29, 2024
app/presenters/bill-runs/two-part-tariff/amend-billable-returns.presenter.js
Outdated
Show resolved
Hide resolved
test/presenters/bill-runs/two-part-tariff/amend-billable-returns.presenter.test.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4370
During the testing of the amended billable returns volume page, it was highlighted that there was 1 validation test missing. When a user enters a new volume for the billable returns currently the volume cannot be greater than the authorised volume on the charge element. This is correct however it should also not go above the charge reference authorised volume. So whichever volume is LOWER the authorised charge element or the authorised charge reference should be the limit for the user's input. This PR is to add in that additional validation.