Fix bill run status badge in bill runs page #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4445 Spotted by our vigilant QA team that we had overlooked bill runs with a status of `'cancel'` need their tag to display as 'cancelling' un the page. This change fixes the issue.
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
and removed request for
Demwunz,
robertparkinson,
Jozzey,
jonathangoulding and
Beckyrose200
Cruikshanks
added a commit
that referenced
this pull request
Apr 26, 2024
https://eaflood.atlassian.net/browse/WATER-4445 We just [fixed the status tag for cancelling bill runs](#945) in the bill runs page when it was spotted the text no longer matched what you see in the legacy service. But this made us realise the same goes for `'processing'` bill runs. They should be displayed as `'building'`. Add to that, it and the tags for anything where a bill run is 'busy' doing stuff (excluding cancelling) should all be grey. With these changes to the tags and the need to be consistent wherever they are shown, we've decided to move the logic into the macro rather than just have it in the `index-bill-runs.presenter.js`. A further change we have made is that any bill run that is busy should not be 'clickable'. It's busy because we are in the process of changing the data for the bill run. Therefore, it doesn't make sense to let users click through and see the in progress or to-be-updated results. So, this change also removes the link for these busy bill runs.
Cruikshanks
added a commit
that referenced
this pull request
Apr 26, 2024
https://eaflood.atlassian.net/browse/WATER-4445 We just [fixed the status tag for cancelling bill runs](#945) in the bill runs page when it was spotted the text no longer matched what you see in the legacy service. But this made us realise the same goes for `'processing'` bill runs. They should be displayed as `'building'`. Add to that, it and the tags for anything where a bill run is 'busy' doing stuff (excluding cancelling) should all be grey. With these changes to the tags and the need to be consistent wherever they are shown, we've decided to move the logic into the macro rather than just have it in the `index-bill-runs.presenter.js`. A further change we have made is that any busy bill run should not be 'clickable'. It's busy because we are in the process of changing the data for the bill run. Therefore, it doesn't make sense to let users click through and see the in-progress or to-be-updated results. So, this change also removes the link for these busy bill runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4445
Spotted by our vigilant QA team that we had overlooked bill runs with a status of
'cancel'and need their tag to display as 'cancelling' on the page.This change fixes the issue.