Update the two-part tariff review tables to include adjustments #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the work on the two-part tariff review pages we getting ready to add new links to review and change the adjustment factors on a charge reference. In preparation for this change the review tables we currently have need to be updated to accommodate these new values. In this preparation we have decided that the column names for the original source data should stay as they are and any new values that are getting persisted should have the word 'amended' in front of the colum name. For example aggregate and amendedAggregate. This PR is for the table migrations and to clear up some previous code that used the column names the wrong way round.
jonathangoulding
pushed a commit
that referenced
this pull request
Apr 29, 2024
As part of the work on the two-part tariff review pages we getting ready to add new links to review and change the adjustment factors on a charge reference. In preparation for this change the review tables we currently have need to be updated to accommodate these new values. In this preparation we have decided that the column names for the original source data should stay as they are and any new values that are getting persisted should have the word 'amended' in front of the colum name. For example aggregate and amendedAggregate. This PR is for the table migrations and to clear up some previous code that used the column names the wrong way round.
Beckyrose200
added a commit
that referenced
this pull request
May 1, 2024
During testing it was noted that the amended billable returns banner broke during a previous PR (#942). It is currently always being displayed. This is because it displays the banner if the amended volume doesn't equal the source volume and since the 'calculated' column no longer exists in the db it therefore never equals each other. This change is to fix the banner to display it only when there is a change to the amended amount.
Beckyrose200
added a commit
that referenced
this pull request
May 1, 2024
During testing it was noted that the amended billable returns banner broke during a previous PR (#942). It is currently always being displayed. This is because it displays the banner if the amended volume doesn't equal the source volume and since the 'calculated' column no longer exists in the db it therefore never equals each other. This change is to fix the banner to display it only when there is a change to the amended amount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work on the two-part tariff review pages, we will be adding new links to review charge reference adjustment factors. In preparation for this change, the review tables need to be updated to add columns for these new values to be stored. We have decided that the column names for all the original values should stay as their descriptive name. Any values that get changed by a user and then persisted should have the word 'amended' in front of the column. For example, aggregate and amendedAggregate, allocated and amendedAllocated. This PR is to update the columns and to clear up previous code that isn't following this naming convention for the persisted data.