Saving input from return requirements in session #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the initial development of the return requirements pages, user input was not being saved in session. Later tickets and pages have this functionality in place. The session data is needed for the Check Your Answers page at the end of the journey. This PR is focused on saving user input into the session where it is missing.
rvsiyad
added
enhancement
…b.com/DEFRA/water-abstraction-system into return-requirements-saving-to-session
… the submitted payload
Cruikshanks
requested changes
Apr 29, 2024
There was a problem hiding this comment.
I hadn't realised that we'd made changes to Site Description to support replaying invalid entries in this PR.
That being the case, if we are making the changes we should look to copy the pattern we used for abstraction period. Shout if that is not clear and we can quickly pair and get this change completed!
I added it in a couple days ago but I have now changed it to copy the new pattern created! |
…k for Object keys is not needed
…b.com/DEFRA/water-abstraction-system into return-requirements-saving-to-session
Cruikshanks
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4384
During the initial development of the return requirements pages, user input was not being saved in session. Later tickets and pages have this functionality in place. The session data is needed for the Check Your Answers page at the end of the journey.
This PR is focused on saving user input into the session where it is missing.