Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from and to date to start and end date #933

Merged
merged 8 commits into from
Apr 29, 2024

Conversation

rvsiyad
Copy link
Contributor

@rvsiyad rvsiyad commented Apr 24, 2024

https://eaflood.atlassian.net/browse/WATER-4296

When creating the abstraction period requirements page, to and from were used to specify the period for the return requirements. This has now been changed to start and end date to match the original error messages in the ticket above.

https://eaflood.atlassian.net/browse/WATER-4296

When creating the abstraction period requirements page, to and from were used
to specify the period for the return requirements. This has now been changed
to start and end date to match the original error messages in the ticket
above.
@rvsiyad rvsiyad added the housekeeping Refactoring, tidying up or other work which supports the project label Apr 24, 2024
@rvsiyad rvsiyad self-assigned this Apr 24, 2024
@rvsiyad rvsiyad marked this pull request as ready for review April 26, 2024 09:30
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, so close! 😂

app/views/return-requirements/abstraction-period.njk Outdated Show resolved Hide resolved
app/views/return-requirements/abstraction-period.njk Outdated Show resolved Hide resolved
@rvsiyad rvsiyad requested a review from Cruikshanks April 29, 2024 09:49
@rvsiyad rvsiyad merged commit c216d12 into main Apr 29, 2024
6 checks passed
@rvsiyad rvsiyad deleted the fix-return-requirements-abstraction-period branch April 29, 2024 11:54
jonathangoulding pushed a commit that referenced this pull request Apr 29, 2024
* Fix from and to date to start and end date

https://eaflood.atlassian.net/browse/WATER-4296

When creating the abstraction period requirements page, to and from were used
to specify the period for the return requirements. This has now been changed
to start and end date to match the original error messages in the ticket
above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants