-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix from and to date to start and end date #933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4296 When creating the abstraction period requirements page, to and from were used to specify the period for the return requirements. This has now been changed to start and end date to match the original error messages in the ticket above.
rvsiyad
added
the
housekeeping
Refactoring, tidying up or other work which supports the project
label
Apr 24, 2024
rvsiyad
requested review from
Demwunz,
Cruikshanks,
robertparkinson,
Jozzey and
Beckyrose200
April 26, 2024 09:30
Cruikshanks
requested changes
Apr 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, so close! 😂
Cruikshanks
approved these changes
Apr 29, 2024
jonathangoulding
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Fix from and to date to start and end date https://eaflood.atlassian.net/browse/WATER-4296 When creating the abstraction period requirements page, to and from were used to specify the period for the return requirements. This has now been changed to start and end date to match the original error messages in the ticket above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4296
When creating the abstraction period requirements page, to and from were used to specify the period for the return requirements. This has now been changed to start and end date to match the original error messages in the ticket above.