Add new check 'busy' bill runs service #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4445 > Part of a series of changes to migrate the legacy view bill runs page into this project In the legacy service we made a change to display a notification banner if a bill run is building or cancelling. But it only works if one of the bill runs on the page being viewed is in that state. Select a page of results that doesn't have a building bill run and the banner goes away. We were limited because we didn't want to break anything with the existing functionality or invest too much in adding new stuff. Now we're migrating the view to this service we have the opportunity to do it right. This service will be used by a another we're adding in a subsequent change to determine which banner to show if any.
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4445
In the legacy service, we made a change to display a notification banner if a bill run is building or cancelling. But it only works if one of the bill runs on the page being viewed is in that state. Select a page of results that doesn't have a building bill run and the banner goes away.
We were limited because we didn't want to break anything with the existing functionality or invest too much in adding new stuff. Now we're migrating the view to this service we have the opportunity to do it right.
This service will be used by another we're adding in a subsequent change to determine which banner to show if any.