Add new fetch bill runs service #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4445 > Part of a series of changes to migrate the legacy view bill runs page into this project In order to view the bill runs we need to fetch them first! This change adds a new service that generates a summary for each bill run for use in a view bill runs page we'll be adding later. A key thing to note about this change is it is the first time we've added an [Objection.js paging query](https://vincit.github.io/objection.js/recipes/paging.html#paging). This service is going to support us adding pagination to our pages for the first time via the [GOV.UK pagination component](https://design-system.service.gov.uk/components/pagination/).
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4445
In order to view the bill runs we need to fetch them first! This change adds a new service that generates a summary for each bill run for use in a view bill runs page we'll be adding later.
A key thing to note about this change is it is the first time we've added an Objection.js paging query. This service is going to support us adding pagination to our pages for the first time via the GOV.UK pagination component.