Fix 2PT volume allocation #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4377 It was found during testing that if the individual return line volumes are greater than the charge reference authorised volume, which in turn is greater than the element authorised volume. That the element was being over allocated. This PR fixes this issue and creates a new unit test to check for it as it wasn't being picked up previously.
test/services/bill-runs/two-part-tariff/allocate-returns-to-charge-element.service.test.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4377
It was found during testing that if the individual return line volumes are greater than the charge reference authorised volume, which in turn is greater than the element authorised volume. That the element was being over-allocated.
This PR fixes this issue and creates a new unit test to check for it as it wasn't being picked up previously.