Fix review licence page #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4219 Following from the testing of the above ticket, two issues with the page was discovered. The first being where we are meant to display the charge reference billable volume this is actually displaying the charge elements and the second issue being a piece of text missing at the top of the page. This PR is to fix those issues.
Beckyrose200
requested review from
Jozzey and
Cruikshanks
and removed request for
Jozzey
Jozzey
requested changes
Apr 11, 2024
test/presenters/bill-runs/two-part-tariff/review-licence.presenter.test.js
Show resolved
Hide resolved
Jozzey
requested changes
Apr 12, 2024
app/presenters/bill-runs/two-part-tariff/review-licence.presenter.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Jason Claxton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4219
Following on from testing the above ticket, an issue with the page was discovered where a piece of text is missing at the top of the page. The text is dynamically shown when there are charge elements that have a status of 'review'. This PR is to add this text.