-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Progress when reviewing Licence in 2PT Bill Run #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4215 Add a button to the review individual licence screen called “Mark Progress”. Clicking this button will mark the licence as in progress, changing the button to “remove progress from licence” and adding a banner to the top of the page. If you then go to the review licences page, that licence will have a tick against it in the progress column.
When running unit tests they are intermittantly failing with this error `insert into "purposes" ("description", "legacy_id", "loss_factor", "two_part_tariff") values ($1, $2, $3, $4) returning * - duplicate key value violates unique constraint "purposes_uses_legacy_id_unique"`
Cruikshanks
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4215
Add a button to the review individual licence screen called “Mark Progress”. Clicking this button will mark the licence as in progress, changing the button to “remove progress from licence” and adding a banner to the top of the page. If you then go to the review licences page, that licence will have a tick against it in the progress column.