Fix return link logic on two-part tariff licence review page #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During some refactoring of the match details page, it was noticed that the logic for generating the returnLog link in the licence review page was in the view and not the presenter. It was also noted that the link for unmatched returns was incorrectly taking the user to the full list of returns and not the actual return they clicked on. This PR fixes the unmatched returns link and moves the logic into the presenter.
Beckyrose200
added
the
housekeeping
Cruikshanks
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some refactoring of the match details page, it was noticed that the logic for generating the returnLog link in the licence review page was in the view and not the presenter. It was also noted that the link for unmatched returns was incorrectly taking the user to the full list of returns and not the actual return they clicked on. This PR fixes the unmatched returns link and moves the logic into the presenter.