Add review badge, rename existing and call it tag! #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4370 A long time back we created a macro for displaying 'badges' for bill runs. These are [GOV.UK tag components](https://design-system.service.gov.uk/components/tag/) and indicate the status of a bill run. We have to display them in so many places it is the only thing to justify having a macro so far. In the work we are doing building the review two-part tariff matches and allocations views we again need badges for statuses. Great! We have a 'badge' macro. Only there are differences. `ready` for bill runs should be displayed as blue. In the review screens it needs to be green. Also, the badges need to be different sizes for the two contexts. We had it in mind to [expand the existing functionality](#882) but that was what made it clear we really need two different badges for the 2 contexts. Which means the existing `badge.njk` macro should also be given a more explicit name. Then the final change; stop calling these blooming things badges. They're tags!
We've excluded where the review licence badge is using it but that's because we intend to use our new review-status-tag. All the rest have been updated though.
Cruikshanks
added
the
housekeeping
Beckyrose200
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4370
A long time back we created a macro for displaying 'badges' for bill runs. These are GOV.UK tag components and indicate the status of a bill run.
We have to display them in so many places it is the only thing to justify having a macro so far.
In the work we are doing building the review two-part tariff matches and allocations views we again need badges for statuses.
Great! We have a 'badge' macro. Only there are differences.
readyfor bill runs should be displayed as blue. In the review screens it needs to be green. Also, the badges need to be different sizes for the two contexts.We had it in mind to expand the existing functionality but that was what made it clear we needed two different badges for the 2 contexts.
This means the existing
badge.njkmacro should also be given a more explicit name.Then the final change; stop calling these blooming things badges. They're tags!