Amend billable volume on element review page #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4370 As part of our two-part tariff bill run work, we've developed licence review pages where you can view the matching details of the two-part tariff engine. When viewing a charge elements matching details you have the option as a user to be able to change the billable volume on the element. This PR covers that functionality.
Beckyrose200
changed the title
|
SonarCloud is currently complaining that there is duplicate code coverage within the amend-billable-returns-presenter. This is valid as there is a lot of duplicated code in the presenters but can be ignored for the time being. The plan is once all the pages have been built, to then go back into all the presenters and services and see what can be de-duplicated. |
Jozzey
requested changes
Apr 24, 2024
test/presenters/bill-runs/two-part-tariff/amend-billable-returns.presenter.js
Outdated
Show resolved
Hide resolved
test/services/bill-runs/two-part-tariff/submit-amended-billable-returns.service.test.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4370
As part of our two-part tariff bill run work, we've developed licence review pages where you can view the matching details of the two-part tariff engine. When viewing a charge elements matching details you have the option as a user to be able to change the billable volume on the element. This PR covers that functionality.