View match details for an element during 2PT review #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4195 As part of our two-part tariff bill run work, we've developed a review page displaying a summary of all licences in a bill run. From there you can view the match details of a specific charge element to any returns it has matched or unmatched. This PR is the journey for the match details page.
Beckyrose200
requested review from
Cruikshanks,
Demwunz,
robertparkinson,
Jozzey and
rvsiyad
Cruikshanks
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Because I've asked for a change to the route used it is going to have knock-on consequences to the other files.
So, I've not completed the review because it'll be easier to make that change then comeback and look through the rest.
Ping me and I'll jump onto this straight again as soon as it is ready.
app/services/bill-runs/two-part-tariff/fetch-view-match-details.service.js
Outdated
Show resolved
Hide resolved
app/services/bill-runs/two-part-tariff/view-match-details.service.js
Outdated
Show resolved
Hide resolved
app/services/bill-runs/two-part-tariff/view-match-details.service.js
Outdated
Show resolved
Hide resolved
Cruikshanks
requested changes
Apr 3, 2024
app/presenters/bill-runs/two-part-tariff/match-details.presenter.js
Outdated
Show resolved
Hide resolved
app/presenters/bill-runs/two-part-tariff/match-details.presenter.js
Outdated
Show resolved
Hide resolved
app/presenters/bill-runs/two-part-tariff/review-licence.presenter.js
Outdated
Show resolved
Hide resolved
app/presenters/bill-runs/two-part-tariff/review-licence.presenter.js
Outdated
Show resolved
Hide resolved
app/services/bill-runs/two-part-tariff/fetch-match-details.service.js
Outdated
Show resolved
Hide resolved
app/services/bill-runs/two-part-tariff/fetch-match-details.service.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4195
As part of our two-part tariff bill run work, we've developed a review page displaying a summary of all licences in a bill run. From there you can view the match details of a specific charge element to any returns it has matched or unmatched. This PR is the journey for the match details page.