Fix FetchMatchingBillRunService for PRESROC 2PT #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4375 In testing it was found that when you complete the journey to setup a PRESROC two-part tariff bill run and selected 'winter and all year' as the season you get a match for the summer 2PT bill run in that year returned. After investigating the issue its not that we are matching the wrong season but that we are not filtering by season at all. If in the environment where the tests were being run the winter 2PT had been created last then it would always be the result returned first. The flaw is a result of initially passing in the values selected in the UI raw, and then switching to transformed values. We always get values back from the UI as strings and this is what we are matching financial year against to determine if we need to apply the season clause to our query. But at some point in our development we changed that to a number, which means it now never matches. ```javascript // financialYearEnding is 2022 not '2022'! if (['2022', '2021'].includes(financialYearEnding)) { query.where('summer', summer) } ``` This change fixes the issue.
The tests were passing before because we were only creating one bill run for each test. The flaw wasn't that no result was found, just that it returned the first 2PT for that region and year regardless of season.
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
robertparkinson
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4375
In testing, it was found that when you complete the journey to set up a PRESROC two-part tariff bill run and select 'winter and all year' as the season you get a match for the summer 2PT bill run in that year returned.
After investigating the issue it's not that we are matching the wrong season but that we are not filtering by season at all. If in the environment where the tests were being run the winter 2PT had been created last then it would always be the result returned first.
The flaw is a result of initially passing in the values selected in the UI raw, and then switching to transformed values. We always get values back from the UI as strings and this is what we are matching financial year against to determine if we need to apply the season clause to our query. But at some point in our development, we changed that to a number, which means it now never matches.
This change fixes the issue.