Fix event timestamps when created for bill run #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3831 We got our migration wrong. For our test DB we have `db/migrations/20221209193845_create-water-events.js` set the timestamps in the `water.events` table to default to `knex.fn.now()` (essentially `Date.now()`). But when testing creating an SROC bill run we spotted that our `event` record didn't have it's timestamps set. Double checking the legacy DB we can see `water.events` timestamps don't have a default value set. So, this change adds a migration to have the test table behave as it does in the legacy DB. It also updates the `app/services/supplementary-billing/create-billing-batch-event.service.js` to ensure they get when creating the record.
We tested both migration and rollback to confirm the changes are as expected. Another thing we spotted was that the legacy DB allows nulls in the `water.events` timestamps. So, when altering the columns we made that change as well.
We need to get the current date as a ISOString to pass to PostgreSQL for reasons explained in the comments. This doesn't feel like reason enough to build a standalone `TimeLib` or `PostgreSqlLib`. But we do need to keep an eye on it and ensure it doesn't become a 'kitchen-drawer' of methods.
It now sets the timestamps as part of creating the record.
Also spotted that the JSONB field `licences` defaults to an empty array. So, fix that whilst we at it.
Cruikshanks
force-pushed
the
fix-bill-run-event-creation
branch
from
67766d6 to
d700f19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3831
We got our migration wrong. For our test DB we have
db/migrations/20221209193845_create-water-events.jsset the timestamps in thewater.eventstable to default toknex.fn.now()(essentiallyDate.now()). But when testing creating an SROC bill run we spotted that oureventrecord didn't have its timestamps set.Double checking the legacy DB we can see
water.eventstimestamps don't have a default value set. So, this change adds a migration to have the test table behave as it does in the legacy DB. It also updates theapp/services/supplementary-billing/create-billing-batch-event.service.jsto ensure they get set when creating the record.