Fix error in match & allocate service crashing app #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4375 Spotted whilst working on [Fix licence issues failing to insert for review](#867). When `PersistAllocatedLicenceToResultsService` errored trying to insert a record it was causing an uncaught exception that was crashing the app. After investigating the issue we have spotted it is because `MatchAndAllocateService` is using a `forEach()` to call asynchronous code. - [Using async/await in a forEach loop (you can't)](https://blog.devgenius.io/using-async-await-in-a-foreach-loop-you-cant-c174b31999bd) - [Do not use forEach with async-await](https://gist.github.com/joeytwiddle/37d2085425c049629b80956d3c618971) If we switch to a `for...of` loop instead any errors thrown within the loop, even from `PersistAllocatedLicenceToResultsService` get caught as expected by the top level `try/catch` in `ProcessBillRun` and the bill run marked as errored. Also, whilst looking into this we spotted that `DetermineLicenceIssuesService` as been made `async` even though it is doing nothing asynchronous. We use this opportunity to fix that as well.
Jozzey
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4375
Spotted whilst working on Fix licence issues failing to insert for review. When
PersistAllocatedLicenceToResultsServiceerrored trying to insert a record it was causing an uncaught exception that was crashing the app.After investigating the issue we have spotted it is because
MatchAndAllocateServiceis using aforEach()to call asynchronous code.If we switch to a
for...ofloop instead any errors thrown within the loop, even fromPersistAllocatedLicenceToResultsServiceget caught as expected by the top leveltry/catchinProcessBillRunand the bill run marked as errored.Also, whilst looking into this we spotted that
DetermineLicenceIssuesServicehas been madeasynceven though it is doing nothing asynchronous. We use this opportunity to fix that as well.