Remove redundant fetch for region code in service #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4375 Spotted whilst working on [Exclude ended charge versions from 2PT billing](#865) that we pass in the region ID to `FetchChargeVersionsService` but then do an additional query to identify the NALD region code for that region. We then use the NALD region code to filter the charge versions when we could just use the region ID directly. This change removes the redundant fetch.
Slight tweak to follow the convention now agreed (use a hyphen; `myParam - The widget for the flurgle`). Also dropped reference to SROC as it is the assumed charge scheme for everything we do. Instead highlight two-part tariff as that is the context this service is used in.
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4375
Spotted whilst working on Exclude ended charge versions from 2PT billing that we pass in the region ID to
FetchChargeVersionsServicebut then do an additional query to identify the NALD region code for that region.We then use the NALD region code to filter the charge versions when we could use the region ID directly.
This change removes the redundant fetch.