Move transaction matching logic to GeneralLib #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4403 We are currently working on updating the supplementary billing engine to incorporate improvements we made to the process when implementing annual billing. One of the things we've been reminded off is that we have multiple services that use the same logic to determine if the charging information for 2 transactions is the same. It's a bit of a scary matching function which we flagged as a TODO to bring into a single place. Now seems a good time to do just that and help simplify the supplementary process.
Cruikshanks
added
the
housekeeping
These are now covered by what we do for the function in the GeneralLib tests. We still have 100% unit test coverage of the service after this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4403
We are currently working on updating the supplementary billing engine to incorporate improvements we made to the process when implementing annual billing.
One of the things we've been reminded of is that we have multiple services that use the same logic to determine if the charging information for 2 transactions is the same. It's a bit of a scary matching function which we flagged as a TODO to bring into a single place.
Now seems a good time to do just that and help simplify the supplementary process.