Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4375
We migrated the create bill run process from the legacy service as part of applying updates to support changes for two-part tariff.
One of the things we had to mirror was how it checks for matching or live bill runs at the end of the journey. In testing, we've found there is a scenario our unit tests and therefore the code didn't cover.
With that scenario the first test is this and the result would be false.
Our mistake is to assume only supplementary bill runs would get past this point. So, the next test is passing causing a match to be returned when it shouldn't.
This change updates the unit tests to include this scenario and then fixes the flaw in our logic.