Implement Charging Module Create Bill Run Service #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3833 We need to be able to send requests to the Charging Module to create new bill runs. This PR implements a service to do this.
We add the simplest method of authentication which is to call our `ChargeModuleTokenService` every time a request is made then add the returned token to our request headers. While doing this we realised that we should have been passing the region and rulest in `options.body` and not simply as part of `options`.
We amend the region query to only return `chargeRegionId`, and replace `.where(...whereArgs).first()` with the `.findOne(...whereArgs)` shorthand
We follow the pattern used elsewhere, where we always return a `response` property; this is the bill run data if we were successful, or the error details if we weren't
Cruikshanks
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3833
We need to be able to send requests to the Charging Module to create new bill runs. This PR implements
ChargingModuleCreateBillRunServiceto do this.