Select the points for the requirements for returns page #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4295 This is PR is focused on adding functionality to page 2 of 11 in the return requirement pages. The pages were previously setup as part of a separate PR to create the user journey.
…m/DEFRA/water-abstraction-system into return-requirements-select-points
…s controller test
…m/DEFRA/water-abstraction-system into return-requirements-select-points
Cruikshanks
requested changes
Mar 22, 2024
There was a problem hiding this comment.
Awesome work! If we've been doing our job properly the whole Get-view-Submit-Validate pattern in our code should start to become clear and you can see how other pages are doing the same thing.
A few things to clear up, and don't be concerned about pinging me if all I've done is confuse things or more likely, got it completely wrong!
test/services/return-requirements/submit-points.service.test.js
Outdated
Show resolved
Hide resolved
Cruikshanks
requested changes
Mar 23, 2024
test/services/return-requirements/submit-points.service.test.js
Outdated
Show resolved
Hide resolved
rvsiyad
added a commit
that referenced
this pull request
Mar 26, 2024
…points page https://eaflood.atlassian.net/browse/WATER-4295 #833 This was a ticket that was thought to have been completed, but upon QA testing by Ven, some licences seem to have duplicated 'abstraction points'. There was a previous check within the code preventing this but it was removed as no duplicating 'point_details' were encountered at that time. This PR will be focused on preventing duplicating abstraction points being present within the list of checkbox points on the return requirements points page.
rvsiyad
added a commit
that referenced
this pull request
Mar 26, 2024
…#861) * Fix issue with duplicated abstraction points for return requirements points page https://eaflood.atlassian.net/browse/WATER-4295 #833 This was a ticket that was thought to have been completed, but upon QA testing by Ven, some licences seem to have duplicated 'abstraction points'. There was a previous check within the code preventing this but it was removed as no duplicating 'point_details' were encountered at that time. This PR will be focused on preventing duplicating abstraction points being present within the list of checkbox points on the return requirements points page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4295
This is PR is focused on adding functionality to page 2 of 11 in the return requirement pages.
The pages were previously setup as part of a separate PR to create the user journey.