Add new Charging Module WaitForStatusRequest #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4390 > Part of a series of changes to migrate the legacy [send a bill run](https://defra.github.io/sroc-charging-module-api-docs/#/bill-run/SendBillRun) to this project The [Charging Module API](https://github.com/DEFRA/sroc-charging-module.api) generates transaction references for every bill in a bill run and creating the transaction files when it receives a `/send` request. It will respond with an immediate `204` but the process can take a some seconds for the larger bill runs. So, clients should not expect a bill run to have a status of `billed` or `billing_not_required` immediately. Because of this clients new to wait for the status to change from `processing`. We're already doing this in a different way in our rebill a bill run code. And, when we finally migrate the refreshing a bill run after the CHA [generates it](https://defra.github.io/sroc-charging-module-api-docs/#/bill-run/GenerateBillRun) we'll need this again. So, we're using this opportunity to create a `WaitForStatusRequest` that should make the things easier for ourselves and avoid any duplication in future.
This will allow us to customise how long we pause between requests. It's more to speed up our unit tests but it also gives us the flexibility to configure the service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4390
The Charging Module API generates transaction references for every bill in a bill run and creates the transaction files when it receives a
/sendrequest. It will respond with an immediate204but the process can take some seconds for the larger bill runs. So, clients should not expect a bill run to have a status ofbilledorbilling_not_requiredimmediately.Because of this clients need to wait for the status to change from
processing. We're already doing this differently in our rebill a bill run code. And, when we finally migrate the refreshing a bill run after the CHA generates it we'll need this again.So, we're using this opportunity to create a
WaitForStatusRequestthat should make things easier for ourselves and avoid any duplication in future.