Add relationship between bill and billing account #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4410 > Part of a series of changes to add support for removing a bill licence back into the billing views We're not ready to implement removing a bill licence from a bill run as it depends on sending requests to the [Charging Module API](https://github.com/DEFRA/sroc-charging-module-api) and running the legacy refresh job to update everything on our side. But we can migrate the confirmation page a user sees when removing a licence. Before we get there though we need to add a relationship that has always existed but only thanks to us switching to view based models is available to use. This updates the `BillModel` and `BillingAccountModel` with relationships that join them We will then be able to extract both bill run, bill and bill licence information in a single [Objection.js query](https://vincit.github.io/objection.js/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4410
We're not ready to implement removing a bill licence from a bill run as it depends on sending requests to the Charging Module API and running the legacy refresh job to update everything on our side.
But we can migrate the confirmation page a user sees when removing a licence. Before we get there though we need to add a relationship that has always existed but only thanks to us switching to view-based models is available to use.
This updates the
BillModelandBillingAccountModelwith relationships that join them We will then be able to extract both bill run, bill and bill licence information in a single Objection.js query.