Fix std charge transaction presenter for S130 #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4409 Our users reported that for licences where the Canal and Rivers Trust agreement (S130) has been applied it isn't displayed against the transaction in the new bill view. We assumed this was just another thing we missed when building the new views. So, we were surprised when we found there is code to handle displaying the Canal and rivers trust agreement. After doing some digging we found out why :rolling_eyes: 🤦♂️ We'd already clocked that for some reason the previous team had made this a text field rather than a boolean, even though we are using it to store true or false. We hadn't clocked was that when the legacy code sets the field it is including a space at the end. Computers being computers means 'true' !== 'true '. This change updates the code to handle this.
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
Jozzey
requested changes
Mar 18, 2024
app/presenters/bill-licences/view-standard-charge-transaction.presenter.js
Outdated
Show resolved
Hide resolved
robertparkinson
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4409
Our users reported that for licences where the Canal and Rivers Trust agreement (S130) has been applied, it isn't displayed against the transaction in the new bill view.
We assumed this was just another thing we missed when building the new views. So, we were surprised when we found there is code to handle displaying the Canal and rivers trust agreement.
After doing some digging we found out why 🙄🤦
We'd already clocked that for some reason the previous team had made this a text field rather than a boolean, even though we are using it to store true or false. We hadn't clocked was that when the legacy code sets the field it includes a space at the end. Computers being computers means 'true' !== 'true '. 😡
This change updates the code to handle this.