Determine if licence is 'billed' #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3868 We also need to know whether a charge version has already been ‘billed’ in the current period. If so we’ll have to ensure it’s credited as part of the bill run before we recalculate the debit. For each charge version that is a candidate for billing, we need to determine if it was included in a `billing_batch` for the current period. For now, the result of this check should be included in the `/check/supplementary` endpoint results, against each charge version. That way we can verify if it is working correctly.
It was decided that checking if a charge version had been included in a bill run was not to be done at this point and we should check if the licence had been included instead. In order to do this we needed to create some new models.
Jozzey
changed the title
|
Initially this ticket referred to the charge version. Following a chat with Alan this was changed to the licence after digging into the structure of the data. |
Cruikshanks
reviewed
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3868
We need to know whether a licence has already been ‘billed’ in the current period. If so we’ll have to ensure it’s credited as part of the bill run before we recalculate the debit.
For each licence that is a candidate for billing, we need to determine if it was included in a
billing_batchfor the current period.For now, the result of this check should be included in the
/check/supplementaryendpoint results, against each licence. That way we can verify if it is working correctly.