Add creating the bill run to end of setup journey #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4375 > Part of a series of changes related to replacing the create bill run journey to incorporate changes for two-part tariff At the end of the bill run setup journey, after checking if [an existing bill run matches the options selected](#810) we create the bill run. This can involve calling one of our own bill run services, sending a request to the legacy [water-abstraction-service](https://github/DEFRA/water-abstraction-service), or both. We need to add the service that handles this in order to complete the migration of the bill run setup journey.
Spotted in tests that when the service determined that the year to use was what the user selected it was returning it as a string. However, for supplementary and annual where it uses the current financial year it was returning a number. This inconsistency was causing a problem for the CreateService (and just is wrong!)
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
robertparkinson
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4375
At the end of the bill run setup journey, after checking if an existing bill run matches the options selected we create the bill run.
This can involve calling one of our bill run services, sending a request to the legacy water-abstraction-service, or both. We need to add the service that handles this to complete the migration of the bill run setup journey.