Add bill runs setup season page to journey #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4375 > Part of a series of changes related to replacing the create bill run journey to incorporate changes for two-part tariff This adds the fourth and final page to the setup bill run journey; select the season. This like [Add bill runs setup financial year page to journey](#805) is only needed temporarily. Two-part tariff bill runs were held during COVID then the SROC ones have been delayed whilst we build an SROC 2PT billing engine. This means we have a backlog so users need to be able to select the year they wish to create the bill run for. If they select a PRESROC year they then need to pick the season. Under PRESROC two-part tariff bill runs were based on whether a licence's abstraction was in summer, or winter and all-year. We need to know what season they wish to generate so we can tell the legacy engine. Once the backlogged PRESROC two-part tariff bill runs are dealt with this page will become redundant. Once all the backlogged two-part tariff bill runs have been dealt with both `/year` and `/season` can be dropped from the journey altogether.
This is the route, controller and view plus supporting service and presenter for the GET `/bill-runs/setup/{id}/season` page.
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4375
This adds the fourth and final page to the setup bill run journey; select the season. This like Add bill runs setup financial year page to journey is only needed temporarily.
Two-part tariff bill runs were held during COVID then the SROC ones have been delayed whilst we build an SROC 2PT billing engine. This means we have a backlog so users need to be able to select the year they wish to create the bill run for.
If they select a PRESROC year they then need to pick the season. Under PRESROC two-part tariff bill runs were based on whether a licence's abstraction was in summer, or winter and all-year. We need to know what season they wish to generate so we can tell the legacy engine.
Once the backlogged PRESROC two-part tariff bill runs are dealt with this page will become redundant. Once all the backlogged two-part tariff bill runs have been dealt with both
/yearand/seasoncan be dropped from the journey altogether.