Review an individual licence page #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4219 As part of our two-part tariff bill run work, we've developed a review page displaying a summary of all licences in a bill run. This PR allows you to click on a specific licence from the review page and review its details within the bill run.
|
The Sonar cloud issues are flagged as duplicated code on my PR. This isn't duplicated code from my PR, it is because I have moved a file out of a folder and put into into a shared area. It thinks that I have duplicated the code from the file because of this. |
Jozzey
requested changes
Mar 27, 2024
test/services/bill-runs/two-part-tariff/fetch-review-licence-results.service.test.js
Outdated
Show resolved
Hide resolved
app/presenters/bill-runs/two-part-tariff/review-licence.presenter.js
Outdated
Show resolved
Hide resolved
app/presenters/bill-runs/two-part-tariff/review-licence.presenter.js
Outdated
Show resolved
Hide resolved
app/presenters/bill-runs/two-part-tariff/review-licence.presenter.js
Outdated
Show resolved
Hide resolved
app/presenters/bill-runs/two-part-tariff/review-licence.presenter.js
Outdated
Show resolved
Hide resolved
app/presenters/bill-runs/two-part-tariff/review-licence.presenter.js
Outdated
Show resolved
Hide resolved
app/presenters/bill-runs/two-part-tariff/review-licence.presenter.js
Outdated
Show resolved
Hide resolved
app/services/bill-runs/two-part-tariff/fetch-review-licence-results.service.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4219
As part of our two-part tariff bill run work, we've developed a review page displaying a summary of all licences in a bill run. This PR allows you to click on a specific licence from the review page and review its details within the bill run.