Fix cancel back link to PRESROC 2pt review #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4387 We spotted a little too late that the `app/views/bill-runs/cancel.njk` view is importing macros it is not using. We know this was because of a copy and paste and doesn't break anything. Still, we don't like to make a habit of importing things and then not using them.
Cruikshanks
force-pushed
the
fix-cancel-back-presroc-review
branch
from
1a17a33 to
21a191a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4387
To make cancelling bill runs more visible in the service we needed to re-implement the cancel bill run feature. Because we've also replaced all the legacy bill run pages we didn't think we'd need to deal with any legacy views.
That was until we spotted that the PRESROC two-part tariff review page is still alive and kicking in the service! You can cancel a bill run from that page so we must support going back to it in our confirm cancel bill run page.
This change makes that so.