Fix badge for empty status #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4396 Unfortunately, we only spotted after [migrating the view empty bill run page](#783) from the legacy service to this one that the status badge was wrong. It should be styled as a grey badge (inactive) but we were displaying it as blue (info). Fixing it required adding an if/else check into 2 views which made us re-think how we were doing the bill run status badges. So, in this change we fix the badge for `empty` and along the way we add a new `statusBadge()` macro that moves the logic of converting bill run status into badge type to one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4396
Unfortunately, we only spotted after migrating the view empty bill run page from the legacy service to this one that the status badge was wrong.
It should be styled as a grey badge (inactive) but we were displaying it as blue (info). Fixing it required adding an if/else check into 2 views which made us re-think how we were doing the bill run status badges.
So, in this change we fix the badge for
emptyand along the way, we add a newstatusBadge()macro that moves the logic of converting bill run status into badge type to one place.