Add submit cancel bill run endpoint #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4387 We need to add this to support our work to improve how bill runs are cancelled. Basically, replace the crummy legacy one! In [Add cancel bill run page](#780) we add the page where the user confirms they want to cancel (delete) the bill run. This final step implements the service that will do the cancelling and the endpoint to trigger it. Unlike the legacy version when we cancel a bill run we'll - immediately update the bill run status to `cancel` - redirect the user to the bill runs page - continue the process of cancelling the bill run in the background This way the user should never see a timeout waiting for a bill run to cancel ever again. It also puts the service into a state where we can start to display to users that a bill run is in the process of being cancelled, the end goal of WATER-4387.
Including the one we forgot for the GET /cancel endpoint. Oops!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4387
We need to add this to support our work to improve how bill runs are cancelled. Basically, replace the crummy legacy one!
In Add cancel bill run page we add the page where the user confirms they want to cancel (delete) the bill run.
This final step implements the service that will do the cancelling and the endpoint to trigger it.
Unlike the legacy version when we cancel a bill run, we'll
cancelThis way the user should never see a timeout waiting for a bill run to cancel ever again. It also puts the service into a state where we can start to display to users that a bill run is in the process of being cancelled, the end goal of WATER-4387.