Add support for DELETE to RequestLib #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4387 We need to add this to support our work to improve how bill runs are cancelled. Basically, replace the crummy legacy one! When you cancel a bill run you need to send a [DELETE request](https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/DELETE) to the [Charging Module API](https://github.com/DEFRA/sroc-charging-module-api) to tell it to delete its copy. Our `RequestLib` module, which is the base module for all HTTP calls doesn't currently have a `delete()` so this change adds it.
Cruikshanks
requested review from
Demwunz,
robertparkinson,
Jozzey,
Beckyrose200 and
rvsiyad
robertparkinson
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4387
We need to add this to support our work to improve how bill runs are cancelled. Basically, replace the crummy legacy one!
When you cancel a bill run you need to send a DELETE request to the Charging Module API to tell it to delete its copy.
Our
RequestLibmodule, which is the base module for all HTTP calls doesn't currently have adelete()so this change adds it.