Rewrite the migrations to match legacy tables #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
added
the
housekeeping
DEFRA/water-abstraction-team#69 > **WARNING** - This will break your test environment. Run `npm run rollback:db:test` before pulling down to prevent this. > Note - Whilst the repo is new, not yet in `production` and we only have a few migrations purely for test purposes we have opted to rewrite rather than 'fix-forward' approach. This change rewrites the existing migrations. We'll be - renaming the files to include which schemas they will be added to - adding timestamp fields that match the original tables - consolidating any changes we've made up to this point This is to ensure our test tables match what we see in the legacy code so we know we're handling the issues we find there and make it clearer what schema a table belongs to.
Match the field names and their properties to what we find in the legacy DB.
Include schema in name (where relevant). Also, be consistent with kebab-case usage (the `20221108143943_*` comes from Knex and is out of our control).
Cruikshanks
force-pushed
the
rewrite-migrations
branch
from
7fc7b03 to
9e2306b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#69
This change rewrites the existing migrations. We'll be
This is to ensure our test tables match what we see in the legacy code so we know we're handling the issues we find there and make it clearer what schema a table belongs to.